rename resource module to asset module #10047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle ReportChanges will increase total bundle size by 216 bytes ⬆️
|
bcoe
reviewed
May 15, 2024
vivianyentran
suggested changes
May 15, 2024
There was a problem hiding this comment.
Changes look fine but you'll want to double check the following before merging:
- Add redirect for this page to middleware.ts (see https://docs.sentry.io/contributing/pages/redirects/#add-a-new-redirect-in-middlewarets-recommended)
- Are the widgets affected by this change? Might need to update these sections:
- https://docs.sentry.io/product/performance/filters-display/widgets/#most-time-consuming-resources
- https://docs.sentry.io/product/performance/filters-display/widgets/#slow-resource-ops
- https://docs.sentry.io/product/performance/filters-display/#actionable-widgets
- Since you're changing the file name, will also want to do a search to update any links that were going directly to the resources page (for example, links here https://docs.sentry.io/product/performance/filters-display/widgets/#most-time-consuming-resources)
We should also update the arcades included in these docs. I can help with that; just give me a heads up for when this change is planning to launch!
|
@vivianyentran we plan to release this on June 5th, r we able to update the arcades by then? Also, do the links need be changed? |
|
@DominikB2014 Yes, we should be able to update the arcades by then. Are all the changes live in the sentry org to capture screenshots? |
|
@DominikB2014 Yes, you should also update any links that point to the old path |
@vivianyentran the updates should be live eod today, I'll follow up with you on slack when it's done! |
DominikB2014
added a commit
to getsentry/sentry
that referenced
this pull request
May 29, 2024
Renaming the `resources` module to `assets` resonates better with FE devs. This does all the renaming in sentry itself, and there's another PR up for docs getsentry/sentry-docs#10047 --------- Co-authored-by: George Gritsouk <[email protected]>
Added redirects!
Yes, just updated the screenshot for this widget No, this one stays the same! Updated the link!
Looked through, and not seeing any more links to be updated |
vivianyentran
approved these changes
Jun 3, 2024
Co-authored-by: vivianyentran <[email protected]>
stephanie-anderson
added a commit
that referenced
this pull request
Jun 11, 2024
* add metrics section and update perf modules (#10209) * Rename performance monitoring to tracing in all platform docs (#10220) * Add new explore folder (#10211) * add new explore folder * Update docs/product/explore/index.mdx Co-authored-by: Liza Mock <[email protected]> * docs(browser): Add missing client param to startBrowserTracingPageLoadSpan (#10215) * Adjust Next.js manual setup docs to be in line with wizard (#10156) Co-authored-by: vivianyentran <[email protected]> * fix(apple): Remove new in version mentions (#10217) Remove new in version mentions for basic options for v 7.x that was released over 1.5 years ago * feat(ruby): Add new onboarding component (#10222) * rm banner for supabase workshop (#10225) * rm banner for supabase workshop * [getsentry/action-github-commit] Auto commit --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com> * fix(issues): severity -> actionability (#10227) * update event detail mentions (#10187) * update event detail mentions * Update docs/product/performance/web-vitals/index.mdx * small tweaks to trace details page * Update docs/product/performance/transaction-summary.mdx Co-authored-by: vivianyentran <[email protected]> * Update docs/concepts/key-terms/tracing/distributed-tracing.mdx * Update docs/platforms/java/guides/spring/advanced-usage.mdx * Update docs/product/performance/resources.mdx Co-authored-by: vivianyentran <[email protected]> * Update docs/product/performance/web-vitals/index.mdx Co-authored-by: vivianyentran <[email protected]> * Update docs/concepts/key-terms/tracing/index.mdx * Update docs/product/performance/mobile-vitals/screen-loads.mdx * Update docs/product/performance/queries.mdx * add redirect * Update docs/concepts/key-terms/tracing/distributed-tracing.mdx * Update docs/platforms/java/guides/spring/advanced-usage.mdx * Update docs/product/performance/queries.mdx * Update docs/concepts/key-terms/tracing/index.mdx * Update docs/product/performance/mobile-vitals/screen-loads.mdx * Update docs/product/performance/transaction-summary.mdx * Update docs/product/performance/resources.mdx * Update docs/product/performance/web-vitals/index.mdx --------- Co-authored-by: vivianyentran <[email protected]> * Update trace view to trace details to reflect UI changes (#10201) Update this docs page to reflect the new name. * feat(python): Use onboarding feature toggles & dedup (#10166) * add missing import (#10214) * fix(node): Fix onboarding import hiding options (#10235) * Fix relay redirects (#10239) * Un-mark bun as beta, cleanup some stuff (#10234) * docs(react): correct import in React v8 migration docs (#10232) * Fix onboarding options jumping (#10236) * fix: don't add padding to onboarding options when they're sticking * delete console.log * fix typo * remove rounded corners from OnboardingOptionButtons --------- Co-authored-by: Stephanie Anderson <[email protected]> * Add section to source maps troubleshooting, suggesting to check source fetching setting (#10230) * Rchhabria/laravel updates (#10202) * laravel blurb * laravel blurb * Create .img * Delete docs/platforms/php/.img * added new forge imgaes * fixed file path * fixed file path * Cache instrumentation links (#10155) * fix: hide platforms with no cache custom instrumentation on cache instrumentation page * add node cache cache instrumentation redirect * add metrics section and update perf modules (#10209) --------- Co-authored-by: Liza Mock <[email protected]> Co-authored-by: Andrei <[email protected]> Co-authored-by: Luca Forstner <[email protected]> Co-authored-by: Philipp Hofmann <[email protected]> Co-authored-by: Neel Shah <[email protected]> Co-authored-by: elijames-codecov <[email protected]> Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com> Co-authored-by: Matt Duncan <[email protected]> Co-authored-by: Ivana Kellyerova <[email protected]> Co-authored-by: Johan Wänglöf <[email protected]> Co-authored-by: Francesco Novy <[email protected]> Co-authored-by: Stephanie Anderson <[email protected]> Co-authored-by: Rob Hannay <[email protected]> Co-authored-by: abdellah hariti <[email protected]> Co-authored-by: Rahul Chhabria <[email protected]> * Add insights page (#10213) * add insights page * Update docs/product/insights/index.mdx Co-authored-by: Liza Mock <[email protected]> --------- Co-authored-by: Liza Mock <[email protected]> * rename resource module to asset module (#10047) * rename resource module to asset module * code review * add note * add images * add redirect * update widget screenshot * Apply suggestions from code review Co-authored-by: vivianyentran <[email protected]> --------- Co-authored-by: vivianyentran <[email protected]> Co-authored-by: vivianyentran <[email protected]> * Move insights (#10273) * move items under insights * update internal insights links * update internal links and move referenced images * remove histogram from web vitals page * Add links to the insights module in the product from the insights manual instrumentation docs. (#10263) * Update billing quota pages for AM3 (#10229) * one more * Update docs/pricing/quotas/index.mdx Co-authored-by: vivianyentran <[email protected]> * Update docs/pricing/quotas/manage-attachments-quota.mdx Co-authored-by: vivianyentran <[email protected]> * deleted outdated images --------- Co-authored-by: vivianyentran <[email protected]> * update arcades for insights (#10278) * update arcades for insights * add business plan note * add caches and queues arcades * feat(performance): adds note about webvitals samples (#10247) Adds a note to clarify web vitals samples list in page overview * feat(ruby): Add queues, caches and requests modules (#10245) * feat(ruby): Add queues, caches and requests modules * Update docs/platforms/ruby/common/performance/instrumentation/custom-instrumentation/caches-module.mdx Co-authored-by: Anton Pirker <[email protected]> --------- Co-authored-by: Anton Pirker <[email protected]> * feat(js): Add new onboarding for all JavaScript guides (#10241) * feat(js): Add docs on how to disable distributed tracing (#10254) * feat(performance): Adds queues instrumentation for more platforms (#10242) Adds custom queues instrumentation docs for java, go, and dotnet Co-authored-by: Alexander Dinauer <[email protected]> * feat: Revamp JS integrations page for v8 (#10138) * feat(node): Add docs for tree shaking in Node (#10257) --------- Co-authored-by: Andrei <[email protected]> * feat(tracing): Update spans section (#10246) - Updating spans section in the tracing page for some changes coming up - Given this is user facing documentation, removing the `(optional)` text since that doesn't make sense given the public api for spans is through `sentry_sdk.start_span()` - Linking to searchable properties (that doesn't exist yet so this PR will need to wait for that) from here if that's what the user is looking for * Update billing docs for AM3 (#10210) * Update docs/platforms/apple/common/tracing/index.mdx Co-authored-by: Liza Mock <[email protected]> * Update docs/platforms/dotnet/common/migration/index.mdx Co-authored-by: Liza Mock <[email protected]> * Update docs/contributing/approach/product-docs/write-index.mdx Co-authored-by: Liza Mock <[email protected]> * Update docs/platforms/python/tracing/index.mdx Co-authored-by: Liza Mock <[email protected]> * Remove obsolete files * feat(.NET): Added new onboarding (#10244) * Document Java SDK cache module (#10264) * Update URLs * move pages * Onboarding options for Go guides * Fix styles for external links * feat(performance): Updates module name to Queues (#10340) Updates Queue Monitoring text to Queues to match actual module name. * docs(traces): Add traces product doc page (#10224) * docs(traces): Add traces product doc page * Update docs/product/traces/index.mdx * Update docs/product/traces/index.mdx * Move traces under explore * Update docs/product/explore/traces/index.mdx * Get rid of sandbox link * Add images * Remove extra homepage image --------- Co-authored-by: Liza Mock <[email protected]> * update concepts docs (#10318) * update concepts docs * Update docs/concepts/key-terms/key-features.mdx * update key features * Update docs/concepts/key-terms/key-terms.mdx Co-authored-by: vivianyentran <[email protected]> * Update docs/concepts/key-terms/key-terms.mdx Co-authored-by: vivianyentran <[email protected]> * Update docs/product/index.mdx Co-authored-by: vivianyentran <[email protected]> * Update docs/product/sentry-basics/index.mdx Co-authored-by: vivianyentran <[email protected]> --------- Co-authored-by: vivianyentran <[email protected]> Co-authored-by: Stephanie Anderson <[email protected]> Co-authored-by: vivianyentran <[email protected]> * update trace explorer nav order (#10346) * update trace explorer nav order * update vercel * feat(tracing): Add searchable span properties (#10327) * adds searchable span properties * Applying suggestions from PR Review Minor copy edits and punctuation Co-authored-by: Liza Mock <[email protected]> * replaced github link to platform list with inline list of platforms * adding suggestions from code review Co-authored-by: vivianyentran <[email protected]> * Update docs/concepts/search/searchable-properties/spans.mdx Co-authored-by: vivianyentran <[email protected]> * Update docs/concepts/search/searchable-properties/spans.mdx Co-authored-by: vivianyentran <[email protected]> * Update docs/concepts/search/searchable-properties/spans.mdx Co-authored-by: vivianyentran <[email protected]> * Update docs/concepts/search/searchable-properties/spans.mdx Co-authored-by: vivianyentran <[email protected]> --------- Co-authored-by: Liza Mock <[email protected]> Co-authored-by: vivianyentran <[email protected]> Co-authored-by: Stephanie Anderson <[email protected]> * Created Metrics Settings Page (#10339) * Created Metrics Settings Page Created Metrics Settings Page * Adding Screenshots * Update metrics-settings.mdx * Apply suggestions from code review apply copyedits * Update docs/product/explore/metrics/metrics-settings.mdx * Apply suggestions from code review * Update docs/product/explore/metrics/metrics-settings.mdx Co-authored-by: vivianyentran <[email protected]> * Update docs/product/explore/metrics/metrics-settings.mdx --------- Co-authored-by: vivianyentran <[email protected]> Co-authored-by: vivianyentran <[email protected]> * Add feature page for ASP .NET Core; add onboarding options to Go guide HTTP * Move files to subfolders --------- Co-authored-by: vivianyentran <[email protected]> Co-authored-by: Liza Mock <[email protected]> Co-authored-by: Andrei <[email protected]> Co-authored-by: Luca Forstner <[email protected]> Co-authored-by: Philipp Hofmann <[email protected]> Co-authored-by: Neel Shah <[email protected]> Co-authored-by: elijames-codecov <[email protected]> Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com> Co-authored-by: Matt Duncan <[email protected]> Co-authored-by: Ivana Kellyerova <[email protected]> Co-authored-by: Johan Wänglöf <[email protected]> Co-authored-by: Francesco Novy <[email protected]> Co-authored-by: Rob Hannay <[email protected]> Co-authored-by: abdellah hariti <[email protected]> Co-authored-by: Rahul Chhabria <[email protected]> Co-authored-by: Dominik Buszowiecki <[email protected]> Co-authored-by: vivianyentran <[email protected]> Co-authored-by: Anton Pirker <[email protected]> Co-authored-by: edwardgou-sentry <[email protected]> Co-authored-by: Alexander Dinauer <[email protected]> Co-authored-by: Abhijeet Prasad <[email protected]> Co-authored-by: William Mak <[email protected]> Co-authored-by: Stefan Jandl <[email protected]> Co-authored-by: Kev <[email protected]> Co-authored-by: Alex Jillard <[email protected]> Co-authored-by: Alexandra Cota <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asset module probably resonates better with FE devs, so we should rename the module